On Fri, 17 Jul 2026 18:53:03 GMT, Justin Lu <[email protected]> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Made the non-conditional case explicit by setting it to "NONE"
>
> make/jdk/src/classes/build/tools/generatespecialcasing/GenerateSpecialCasing.java
> line 49:
>
>> 47: public class GenerateSpecialCasing {
>> 48: // Record for a code point that holds the conditional special casing
>> 49: private static record Entry(String codePoint, List<String>
>> lowerCase, List<String> upperCase, String language, String condition) {};
>
> Could briefly mention that `language` is nullable, which indicates that the
> entry mapping is locale-independent.
I changed not to allow `null` for `language`, used empty String to represent
all languages, which is more aligned with `Locale.ROOT`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31937#discussion_r3606293627
