On Thu, 23 Jul 2026 07:56:53 GMT, Guanqiang Han <[email protected]> wrote:
>> Please review this change, thanks! >> >> **Description:** >> >> Some VM long options only accept arguments in the `--option=value` form, >> even though the launcher help states that long-option arguments may also be >> separated by whitespace. As a result, options such as >> `--illegal-final-field-mutation debug`, `--illegal-native-access warn` are >> not parsed correctly. >> >> **Solution:** >> >> Add `IsNonModuleVMWhiteSpaceOption()` to identify VM long options that >> accept whitespace-separated arguments and convert them to the >> `--option=value` form before passing them to the VM. Add >> `--enable-final-field-mutation` to the existing module-option handling. >> Normalize missing arguments for other VM long options to `--option=` so that >> they can be handled by the existing option validation logic. >> >> **Test:** >> >> GHA >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Guanqiang Han has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains five additional > commits since the last revision: > > - Update existing tests for this change > - Merge remote-tracking branch 'upstream/master' into 8387729 > - Fix an error of other test caused by this change > - Align method arguments > - fix JDK-8387729 test/jdk/java/lang/Object/FinalizationOption.java line 2: > 1: /* > 2: * Copyright (c) 2021, 2026 Oracle and/or its affiliates. All rights > reserved. A comma is missing here after `2026`. Same with a few other files in this PR. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31928#discussion_r3655818027
