On Fri, 17 Jul 2026 15:37:24 GMT, Ashay Rane <[email protected]> wrote:
>> On both ReFS and removable drives, the primary path in libGetXSpace.c, >> (which calls `GetDiskSpaceInformationW()` API function) fails because >> the API call fails. When that happens, the code throws an exception, >> causing the test to fail. >> >> The key change in this patch is to switch to the fallback path (of >> calling `GetDiskFreeSpaceExW()` to estimate the disk space) when >> `GetDiskSpaceInformationW()` fails, making the test pass on machines >> that have such non-standard volumes. This has the ancillary benefit of >> handling _all_ kinds of removable drives, so this patch removes the >> special case for handling CDROM drives (whose code shelled out to "df", >> which doesn't exist outside of Cygwin and MSys/MinGW). >> >> This patch also fixes the return types and their handling for both >> `GetDiskSpaceInformationW()` and `GetDiskFreeSpaceExW()` to match the >> Windows API documentation. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Ashay Rane has updated the pull request incrementally with one additional > commit since the last revision: > > Fix comment @raneashay Your change (at version 38f0ff86a09f2dde2e1725315ddf9467292e1c0c) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk/pull/31682#issuecomment-5094161591
