On Thu, 30 Jul 2026 13:52:20 GMT, Alan Bateman <[email protected]> wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address jar spec change
>
> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/xs/XMLSchemaLoader.java
> line 615:
>
>> 613: }
>> 614:
>> 615: if (fXSDDescription.isExternal() &&
>> !source.isCreatedByResolver()) {
>
> The parameter is "desc", is this checking the right XSDDescription?
Yes, the global variable is correct here as processJAXPSchemaSource may set the
loader’s description to CONTEXT_PREPARSE; using desc.isExternal() would
incorrectly treat a parser-configured schema as externally discovered. It's not
ideal, but the result of tangled web of dependencies. The code is a mixture of
legacy validation and twice revamped validation API, so many code routes
intertwine. XMLSchemaValidator can call this method with its own desc - that I
think the author tried to avoid modifying.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32098#discussion_r3694085198
