Reopened Valhalla PR which did not go in before the code freeze (openjdk/valhalla#2405).
The original PR was review by @jsikstro and @johan-sjolen. > There are few places which uses the fully qualified name for the AsValueClass > annotation. As a result the plugging does not modify these classes when > compiling, so they are still identity classes. > > I propose improving the robustness of this plugin. We need to do this during > parsing so we cannot actually check 100% that it will resolve to the correct > annotation. However we can do a best effort, which handles same package, > fully qualified, imported and rejects other annotations with the same class > name. This only adapts the current ValueClassPlugin to be more robust, there might be room for improving how we do this Value class transformation in some other way. * Testing * Verified that enable preview testing classes are transformed, including `gc/stress/gcbasher` which was missed before this change. * Testing tests with annotation with and without enable preview --------- - [x] I confirm that I make this contribution in accordance with the [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). ------------- Commit messages: - 8384068: ValueClassPlugin misses some annotations Changes: https://git.openjdk.org/jdk/pull/32214/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=32214&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8384068 Stats: 65 lines in 1 file changed: 60 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/32214.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/32214/head:pull/32214 PR: https://git.openjdk.org/jdk/pull/32214
