On Mon, 10 Aug 2026 17:12:51 GMT, Matias Saavedra Silva <[email protected]> 
wrote:

>> [JDK-8376522](https://bugs.openjdk.org/browse/JDK-8376522) indicates that 
>> the thisUninit should be applied even when uninitializedThis is on the 
>> stack. Previous implementations failed to do this, so this patch properly 
>> enforces this spec change. 
>> 
>> Now that both the stack and locals must be considered when applying 
>> flagThisUninit, the origin of the flag needs to  be preserved, so the 
>> StackMapReader now tracks if the flag originated from locals or the stack. 
>> Since the stack is cleared between frames, only an uninitializedThis from 
>> locals is preserved. 
>> 
>> In addition to VM changes, the ClassFile API had to be updated as it only 
>> considered stack frame locals. The test case offered by @liach in the JBS 
>> issue has been adapted to a JASM test to verify the change. Verified with 
>> tier 1-5 tests.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Matias Saavedra Silva has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Removed unnecessary if and added assert

Still good.

-------------

Marked as reviewed by fparain (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/32242#pullrequestreview-4899628445

Reply via email to