On Fri, 31 Jul 2026 00:55:46 GMT, Chen Liang <[email protected]> wrote:

> When the JVM of javac runs with -J--enable-preview, javac should still 
> compile against the non-preview class path when it is not passed 
> --enable-preview. We have this hack within InMemoryJavaCompiler that turns 
> out breaks things when we try to fix some javac issues 
> (openjdk/valhalla#2643), because we expect the output bytecode to be stable 
> for transformations.
> 
> We should remove this hack, which will break all InMemoryJavaCompiler usage 
> that already pass explicit `--enable-preview` and `-source` options.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Good.

-------------

Marked as reviewed by kvn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/32112#pullrequestreview-4899666256

Reply via email to