On Wed, 12 Aug 2026 18:41:10 GMT, Coleen Phillimore <[email protected]> wrote:
>> I don't see that check that it's a built-in loaders (or assert) here. > > I think I understand Alan's question. His question is any class loader might > do something like skip normal delegation and call > MyFooOtherClassLoader.getResource(), so you need to know that it's a normal > delegating class loader. > So builtin_class_loaders - like the AppClassLoader (ie the normal system > loader) will have a normal delegation and not bypass it to find something > strange. Did I get this right? > Maybe don't need an assert like > assert(SystemDictionaryShared::is_builtin_loader(loader_data) because this > case always comes through. > Maybe a comment would suffice. This code path only exists inside `ClassLoader::record_result_for_builtin_loader` so I think we're safe here. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32087#discussion_r3769979464
