On Thu, 13 Aug 2026 15:48:01 GMT, Patricio Chilano Mateo <[email protected]> wrote:
>> `VerifyStackChunkFrameClosure` calls `StackChunkFrameStream::frame_size` to >> compute the sizes of frames stored in the `stackChunk`, but that method >> incorrectly uses `cb()->frame_size()` for extended compiled frames. The >> actual frame size has to be read from the frame metadata recorded when the >> frame was extended. >> >> Thanks to @TobiHartmann for the small reproducer which I included in the PR. >> I also tested the fix running `TestVirtualThreads.java` and `Fuzz.java` with >> `-XX:+VerifyContinuations` which also triggered the same assert before this >> fix. >> >> Thanks, >> Patricio >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Patricio Chilano Mateo has updated the pull request with a new target base > due to a merge or a rebase. The incremental webrev excludes the unrelated > changes brought in by the merge/rebase. The pull request contains seven > additional commits since the last revision: > > - update frame::was_augmented_on_entry() for s390 > - Merge branch 'master' into JDK-8389187 > - extra test flags + copyright update > - fix copyright header > - addd extra @test with -XX:+VerifyContinuations > - fix assert > - v1 Looks good. Thank you Patricio. ------------- Marked as reviewed by fbredberg (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/32178#pullrequestreview-4930996916
