On Tue, 18 Aug 2026 01:46:04 GMT, David Holmes <[email protected]> wrote:
> The JBS description of the problem and solution no longer matches what is > actually being done. I really don't understand the changes being made. What do you mean "what is actually being done"? You asked for ClassDefine events to be issued after a class is actually selected, later, instead of trying to protect for errors. That is what is being done. > src/hotspot/share/classfile/vmClasses.cpp line 274: > >> 272: Dictionary* dictionary = loader_data->dictionary(); >> 273: dictionary->add_klass(THREAD, klass->name(), klass); >> 274: > > Why the reordering of the adding to the dictionary here? To align with all other definition orderings: 1. Add to hierarchy. 2. Add to dictionary. No reason for why this site would have it the other way. ------------- PR Comment: https://git.openjdk.org/jdk/pull/32218#issuecomment-5324944917 PR Review Comment: https://git.openjdk.org/jdk/pull/32218#discussion_r3801896610
