On Tue, 18 Aug 2026 12:12:34 GMT, Casper Norrbin <[email protected]> wrote:

>> Ivan Bereziuk has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   space alias fix. comment tweak
>
> Looks good! Just one small comment nit.

@caspernorrbin Thank you for the review, Casper.

> test/jdk/jdk/internal/platform/docker/MetricsMemoryTester.java line 75:
> 
>> 73: 
>> 74:         // We need swap to execute this test. Otherwise OOM killer acts 
>> with
>> 75:         // SIGSEGV before we read the fail counter.
> 
> The OOM killer sends out a `SIGKILL`, not a `SIGSEGV`

right. I see exit status is 137 which is 128 + 9 (SIGKILL).
I will correct this shortly.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32300#issuecomment-5328614493
PR Review Comment: https://git.openjdk.org/jdk/pull/32300#discussion_r3804294144

Reply via email to