On Thu, 20 Aug 2026 19:42:43 GMT, Brent Christian <[email protected]> wrote:

>> Guanqiang Han has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Adjust code structure and add comments
>
> test/jdk/java/lang/Object/FinalizationOption.java line 162:
> 
>> 160:                     "expected one or two arguments");
>> 161:         }
>> 162:     }
> 
> Perhaps a nit, but can we keep the main() as the first method, before 
> `launch()` and `test()`? That way you understand the flow of the test as 
> you're reading through the file, and already know what `launch()` and 
> `test()` are for once you get to them.

Fixed. Thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31928#discussion_r3826341367

Reply via email to