On Fri, 21 Aug 2026 20:23:59 GMT, Naoto Sato <[email protected]> wrote:

>> This PR implements [JEP 540: Simple JSON API 
>> (Incubator)](https://openjdk.org/jeps/540).
>> 
>> It adds the `jdk.incubator.json` module which provides APIs for reading and 
>> writing JSON documents as specified by [RFC 
>> 8259](https://datatracker.ietf.org/doc/html/rfc8259). This is an incubating 
>> API.
>> 
>> API documentation: 
>> https://cr.openjdk.org/~naoto/json/javadoc/api/jdk.incubator.json/module-summary.html
>> Co-authored-by: Justin Lu 
>> ([@justin-curtis-lu](https://github.com/justin-curtis-lu))
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Naoto Sato has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - Merge remote-tracking branch 'jdk-sandbox/json' into 
> JDK-8381976-Implementation-for-Simple-JSON-API
>  - Print ASCII non-control characters as is in error messages

src/jdk.incubator.json/share/classes/jdk/incubator/json/JsonParseException.java 
line 64:

> 62:      *         in UTF-16 code units. Non-negative.
> 63:      * @throws IllegalArgumentException if either {@code line} or {@code 
> pos} are
> 64:      *      negative

It would more usual to use "either .. or".  I think it would be simpler to just 
say "if line or pos is negative".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32282#discussion_r3835490508

Reply via email to