On Tue, 25 Aug 2026 21:44:18 GMT, Stuart Marks <[email protected]> wrote:
>> Bill Huang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Implement review comment
>
> test/jdk/java/util/HashMap/ToArray.java line 179:
>
>> 177: checkToArray("Empty-tuple-keys", new VClass[0], map.keySet(),
>> !ordered);
>> 178: checkToArray("Empty-tuple-values", new VClass[0], map.values(),
>> !ordered);
>> 179: }
>
> More duplication with checkMap. I think we need to put some effort into
> reusing test logic between tests for identity classes and value classes.
>
> Missing "checkVClassSet` ?
`checkVClassSet` is not needed as the existing `checkSet` has already covered
Long class which is a value class when preview feature is enabled.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32201#discussion_r3882523173
