On Mon, 31 Aug 2026 22:40:00 GMT, Naoto Sato <[email protected]> wrote:
>> Some RegCloseKey calls on hSubKey are missing; and the "NT 4.0 SP3" coding >> in the file looks a bit outdated - is it maybe some leftover from older >> coding ? >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Looks good to me. > >> The whole coding below (line 320 and following) looks strange > > Yeah, it does. As far as I can dig, this is the issue that introduced the > piece: https://bugs.openjdk.org/browse/JDK-4400869, which suggests Windows > implementations were fragile across versions and/or languages. So I guess it > makes sense to just remove this piece, but that is for another opportunity. > Hi @naotoj , thanks for the review ! > > > So I guess it makes sense to just remove this piece, but that is for > > another opportunity. > > Should I open another JBS issue ? That would be apprecitated. I don't expect removing that piece would cause any regressions, but I'd still want to test it thoroughly across several Windows configurations. ------------- PR Comment: https://git.openjdk.org/jdk/pull/32608#issuecomment-5498191367
