On Sun, 6 Sep 2026 05:05:05 GMT, Quan Anh Mai <[email protected]> wrote:

>> Hi,
>> 
>> This PR implements addition and subtraction of 128-bit integers in C2. This 
>> may have numerous applications:
>> 
>> - It helps intrinsification of operations on 128-bit integers when we have 
>> one.
>> - It allows computation that may be incorrect at `long` due to overflow, 
>> such as loop predication of long range checks.
>> 
>> By implementing this separately, we don't need to worry about finalizing a 
>> public API, and we can have a better testing coverage.
>> 
>> Testing:
>> 
>> - [x] tier1-4,hs-comp-stress
>> 
>> Please take a look and leave your review, thanks a lot.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Quan Anh Mai has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Rename to jdk.internal.math.Int128Math

Java code looks good. Didn't spot any problem in the hotspot code either.

-------------

Marked as reviewed by liach (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/31008#pullrequestreview-5124241526

Reply via email to