On Tue, 8 Sep 2026 12:50:22 GMT, Jorn Vernee <[email protected]> wrote:
>> test/jdk/java/foreign/detachafterexit/TestDetachAfterExit.java line 57: >> >>> 55: // note that it's important to use >>> ProcessTools.startProcess here since this makes sure output streams of the >>> 56: // fork don't fill up, which could make the process stall >>> while writing to stdout/stderr >>> 57: Process process = >>> ProcessTools.startProcess(Runner.class.getName(), pb, null, null, 1L, >>> TimeUnit.MINUTES); >> >> Should we add a predicate for the line consumer here (i.e, waiting for >> `[await_join]`)? I think otherwise the timing parameters are just ignored? > > Huh, that's a bit surprising. I'll add a predicate. I had another look at this, and the timeout isn't for the process, it's just waiting for the 'warmup' of the process. I changed the code to call the simpler overload of `starProcess`, and I now wait on that explicitly instead. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32686#discussion_r3960018951
