On Mon, 14 Sep 2026 11:17:21 GMT, Jorn Vernee <[email protected]> wrote:
>> Implement a method handle combinator that can be used to synchronize on an
>> object monitor while executing a given target method handle.
>>
>> The returned method handle behaves similar to the notional code:
>>
>>
>> R adapter(Object lock, A... a) throws Throwable {
>> synchronized (lock) {
>> return body.invokeExact(a...);
>> }
>> }
>>
>>
>> The lambda form is similar to existing ones: we box up all the arguments for
>> the body handle, call a fallback function which synchronizes and invokes the
>> body with the boxed argument, then the `Object` result is fed to an unboxing
>> handle to unbox the result if needed.
>>
>> There's a corresponding intrinsic in `InvokerBytecodeGenerator` which
>> replaces these three operations with `monitorEnter`/`monitorExit`
>> instructions, direct argument/return value forwarding without (un)boxing,
>> and the necessary exception handling which makes sure we unlock the lock
>> again in case the body throws an exception. The generated code is similar to
>> what javac generates.
>>
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Jorn Vernee has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Use ARG_LIMIT
> - remove data param
TBH My review commwnts can go to separate RFEs for this whole class. We can
proceed now.
-------------
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/32817#pullrequestreview-5196970231