On Wed, 16 Sep 2026 12:26:25 GMT, Daniel Fuchs <[email protected]> wrote:
>> Timofei Fedotov has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Add new subtests in regression test >> - Add assert in Rdn constructor > > src/java.naming/share/classes/javax/naming/ldap/Rdn.java line 184: > >> 182: entries = new ArrayList<>(rdn.entries.size()); >> 183: entries.addAll(rdn.entries); >> 184: assert !entries.isEmpty(); > > Here is fine too, but I meant in the constructor above, since `(new > Rfc2253Parser(rdnString)).parseRdn(this)` is supposed to throw when no > entries are added I also could add the second assert in Rfc2253Parser(rdnString)).parseRdn(this), or is it redundant? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32648#discussion_r4026049575
