On Thu, 17 Sep 2026 12:49:11 GMT, Axel Boldt-Christmas <[email protected]> wrote:
>> Reopened Valhalla PR which did not go in before the code freeze >> (openjdk/valhalla#2405). >> >> The original PR was review by @jsikstro and @johan-sjolen. >>> There are few places which uses the fully qualified name for the >>> AsValueClass annotation. As a result the plugging does not modify these >>> classes when compiling, so they are still identity classes. >>> >>> I propose improving the robustness of this plugin. We need to do this >>> during parsing so we cannot actually check 100% that it will resolve to the >>> correct annotation. However we can do a best effort, which handles same >>> package, fully qualified, imported and rejects other annotations with the >>> same class name. >> >> This only adapts the current ValueClassPlugin to be more robust, there might >> be room for improving how we do this Value class transformation in some >> other way. >> >> * Testing >> * Verified that enable preview testing classes are transformed, including >> `gc/stress/gcbasher` which was missed before this change. >> * Testing tests with annotation with and without enable preview >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Axel Boldt-Christmas has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains nine additional > commits since the last revision: > > - Merge remote-tracking branch 'upstream_jdk/master' into JDK-8384068 > - Fix annotation which were missed by the current parser > - Remove the ValueClassPlugin changes > - Revert ValueClassPlugin changes > - Working test > - Try add value class plugin test > - Merge remote-tracking branch 'upstream_jdk/master' into JDK-8384068 > - Merge remote-tracking branch 'upstream_jdk/master' into JDK-8384068 > - 8384068: ValueClassPlugin misses some annotations Marked as reviewed by jsjolen (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/32214#pullrequestreview-5245415498
