On Tue, 22 Sep 2026 19:14:29 GMT, Sandhya Viswanathan
<[email protected]> wrote:
>> Mohamed Issa has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove AVX10.2 fp16 to byte direct conversion vector instruction as it
>> causes correctness issues.
>
> test/micro/org/openjdk/bench/jdk/incubator/vector/Float16ToIntegralConvBenchmark.java
> line 61:
>
>> 59: IntStream.range(0, size).forEach(
>> 60: i -> {
>> 61: if ((i % 100) == 0) {
>
> The if (i % 100) could now be removed.
This will make all entries in fp16inp array special values. Aren't we only
looking to have every 100th element be a special value?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32957#discussion_r4077335491
