On Mon, 28 Sep 2026 18:24:45 GMT, Justin Lu <[email protected]> wrote:

>> This PR corrects a case when the explicit DST offset metazone mapping is 
>> used by `SimpleDateFormat` even when a custom time zone is active.
>> 
>> For example, one can create a custom time zone named "America/Vancouver" 
>> that has no daylight time. The code before this fix would attempt to match 
>> the custom zones total offset to the CLDR metazone dstoffset to determine 
>> daylight time.
>> 
>> Such custom zones should not consult the metazone dstoffset mapping to 
>> determine their daylight naming. Note that it is fine for custom names to be 
>> used with a standard zone and still go through the metazone mapping.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Justin Lu has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Reflect review comments (replace isDirty and hasSameRules for equals) + 
> simplify modified zone test a little

Thank you for the review!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33074#issuecomment-5894289299

Reply via email to