On Fri, 2 Oct 2026 23:14:28 GMT, Dean Long <[email protected]> wrote:
>> Jorn Vernee has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Use getNMethod to check for scoped access
>> - Use reference
>
> src/hotspot/share/prims/scopedMemoryAccess.cpp line 261:
>
>> 259: }
>> 260: #endif
>> 261: if (f_is_session_live && f_has_scoped_access) {
>
> Wouldn't it be better to avoid the call to is_session_live() if
> f_has_scoped_access is false?
Yes, good catch. We can probably just do the scan again when logging is turned
on, and then short-circuit in the production code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30926#discussion_r4183509220
