On Mon, 28 Sep 2026 05:31:41 GMT, Jatin Bhateja <[email protected]> wrote:
>> Hi All, >> >> COMPRESS_BITS and EXPAND_BITS advertise compatibility with all integral lane >> types, but ByteVector/ShortVector had no implementation and threw >> UnsupportedOperationException. >> >> This patch extends COMPRESS_BITS and EXPAND_BITS to the sub-word integral >> types byte and short, covering all integral types. >> >> The changes encompass: >> - Java-side fallback handling for ByteVector and ShortVector. >> - Inline expander side changes. >> - C2/VectorSupport type plumbing for T_BYTE/T_SHORT. >> - Classifying CompressBits/ExpandBits as non-truncating in SuperWord so >> subword stores of Integer.compress do not crash debug builds. >> - Extending Vector API jtreg tests to cover byte and short COMPRESS_BITS and >> EXPAND_BITS. >> >> Please review and share your feedback. >> >> Best Regards, >> Jatin >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Jatin Bhateja has updated the pull request incrementally with one additional > commit since the last revision: > > Review comments resolution Tier 1 to 3 testing passed. Just one comment about restoring the `@since 19` tag. You need a HotSpot person to also review. src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorOperators.java line 591: > 589: /** Produce {@code rotateRight(a,n)}. Integral only. */ > 590: public static final /*bitwise*/ Binary ROR = binary("ROR", > "rotateRight", VectorSupport.VECTOR_OP_RROTATE, VO_SHIFT+VO_NOFP); > 591: /** Produce {@code compress(a,n)}. Integral only. I just noticed you removed the `@since 19` can you please add it back. ------------- Marked as reviewed by psandoz (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/33050#pullrequestreview-5449866341 PR Review Comment: https://git.openjdk.org/jdk/pull/33050#discussion_r4213268722
