On Mon, 12 Oct 2026 06:47:16 GMT, Vladimir Petko <[email protected]> wrote:
>> Implement suggestions in https://bugs.openjdk.org/browse/JDK-8387577. >> This PR uses "approximate" pc that matches the registration offset of oops >> map. >> >> >> Testing - tier1 and tier2 test run >> >> make test TEST=":tier1 :tier2" CONF=linux-s390x-server-fastdebug >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> SKIP >>>> jtreg:test/hotspot/jtreg:tier1 3887 3411 8 0 >>>> 468 << >> jtreg:test/jdk:tier1 2656 2605 0 0 >> 51 >> jtreg:test/langtools:tier1 4775 4763 0 0 >> 12 >> jtreg:test/jaxp:tier1 0 0 0 0 >> 0 >> jtreg:test/lib-test:tier1 41 41 0 0 >> 0 >>>> jtreg:test/hotspot/jtreg:tier2 1059 846 3 0 >>>> 210 << >>>> jtreg:test/jdk:tier2 4609 4351 2 0 >>>> 256 << >> jtreg:test/langtools:tier2 14 12 0 0 >> 2 >> jtreg:test/jaxp:tier2 524 523 0 0 >> 1 >> jtreg:test/docs:tier2 4 0 0 0 >> 4 >> ============================== >> TEST FAILURE >> >> Failed tests also fail on master branch for the same reason, >> test/hotspot/jtreg/runtime/ErrorHandling/CreateCoredumpOnCrash.java` passes >> after enabling `ulimit -c unlimited`. >> >> >> ============================== >> Test summary >> ============================== >> TEST TOTAL PASS FAIL ERROR >> SKIP >> >> jtreg:test/hotspot/jtreg/compiler/c2/igvn/TestOptimizeTrichotomy.java#Xcomp >>>> 1 0 1 0 >>>> 0 << >> >> jtreg:test/hotspot/jtreg/compiler/c2/igvn/TestOptimizeTrichotomy.java#vanilla >>>> 1 0 1 0 >>>> 0 << >> >> jtreg:test/hotspot/jtreg/compiler/escapeAnalysis/TestBCEscapeAnalyzerOverflow.java >>>> 1 0 1 0 >>>> 0 << >> jtreg:test/hotspot/jtreg/compiler/gcbarriers/TestZGCBarrierElision.java#Z >>>> 1 0 1 0 >>>> 0 << >> >> jtreg:test/hotspot/jtreg/compiler/loopopts/superword/TestDoNotFilterNaNSummands.java >>>> ... > > Vladimir Petko has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains 29 additional > commits since the last revision: > > - improve calls_return_pc diagnostic comment > > Co-authored-by: Richard Reingruber <[email protected]> > - fix: improve z_common_abi comment > > Co-authored-by: Richard Reingruber <[email protected]> > - (calls_return_pc == __ last_calls_return_pc()): apply diagnostic message > fix > > Co-authored-by: Richard Reingruber <[email protected]> > - Merge remote-tracking branch 'origin/master' into HEAD > - fix: indentation typo > > Co-authored-by: Amit Kumar <[email protected]> > - pd_last_frame(): add comment on null pc > - Revert "pd_last_frame(): assign z_common_abi->return_pc for runtime stub" > > This reverts commit c1c83d267e1bd475c7ef7032284c3e3a9545bf99. > - pd_last_frame(): assign z_common_abi->return_pc for runtime stub > - fix copyright typo > - fix typos in code > - ... and 19 more: https://git.openjdk.org/jdk/compare/428e721d...6dedd1ac src/hotspot/cpu/s390/frame_s390.hpp line 81: > 79: // Common ABI. On top of all frames, C and Java. > 80: // Note: return_pc is stored in R14 for C frames > 81: // and is null here. Suggestion: // Note: return_pc is only valid for Java calls. // Calls following the native convention would use // z_abi_160_base::gpr14 to save their return pc. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33262#discussion_r4245323112
