On Wed, 14 Oct 2026 17:44:43 GMT, Vicente Romero <[email protected]> wrote:

>> After this PR value classes that override method Object::finalize will get a 
>> compiler error instead of a warning
>> 
>> TIA
>> 
>> ---------
>> - [X] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Vicente Romero has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains 18 commits:
> 
>  - removing javadoc
>  - Merge branch 'master' into JDK-8339188
>  - minor change
>  - another test case
>  - Merge with master
>  - addressing review comments
>  - Object API
>  - object api
>  - changing Object API
>  - changing error message
>  - ... and 8 more: https://git.openjdk.org/jdk/compare/b0024397...f6a59e57

Marked as reviewed by dlsmith (Committer).

Looks good.

Have you considered jasm files for the tests rather than jcod? They don't need 
explicit constant pools or other fiddly bits, can be smaller and easier to edit 
directly.

-------------

PR Review: https://git.openjdk.org/jdk/pull/32355#pullrequestreview-5575965831
PR Comment: https://git.openjdk.org/jdk/pull/32355#issuecomment-6274368833

Reply via email to