On Mon, 19 Oct 2026 23:04:20 GMT, Justin Lu <[email protected]> wrote:

>> Naoto Sato has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Addresses review comments
>
> test/jdk/sun/util/calendar/ZoneRulesDataValidation.java line 76:
> 
>> 74: 
>> 75:     @ParameterizedTest
>> 76:     @MethodSource("maxValue")
> 
> Probably cleaner to split this up into a too large and too small test since 
> the negative size case doesn’t use the max value supplied by the method 
> source.

That is clearer. Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33420#discussion_r4319975419

Reply via email to