On Fri, 16 Oct 2026 12:31:36 GMT, Jorn Vernee <[email protected]> wrote:
>> Currently the javadoc of Linker has many examples that use the `JAVA_*` >> layout constants. >> >> It is preferred for users to use the canonical layouts the linker returns, >> since they have a much more obvious mapping to native types, and are >> guaranteed to work. >> >> This patch tweaks the examples to be written in terms of canonical layouts >> rather than the `JAVA_*` constants. It adds a missing column to the table of >> example types that lists their canonical layout name (which doesn't match >> the C type name for `void*`). >> >> Since this is a doc clarification, no CSR is needed. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Jorn Vernee has updated the pull request incrementally with one additional > commit since the last revision: > > Change JAVA_INT to C_INT in call to toArray src/java.base/share/classes/java/lang/foreign/Linker.java line 184: > 182: * <td style="text-align:center;">{@code boolean}</td> > 183: * <td style="text-align:center;">{@code bool}</td> > 184: * <td style="text-align:center;">{@code C_BOOLEAN}</td> Shouldn't it be `C_BOOL`? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33411#discussion_r4324004042
