On Mon, 19 Oct 2026 20:54:13 GMT, Alexey Semenyuk <[email protected]> wrote:
> Add the upgrade code as input to the function that calculates the stable > Component GUID. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Looks good with minor comments. src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WixAppImageFragmentBuilder.java line 419: > 417: } > 418: > 419: if (regKeyPath.isEmpty()) { I think it is better to use `else` here without additional if. `else` from `if (regKeyPath.isPresent())` check. test/jdk/tools/jpackage/windows/Win8394606Test.java line 57: > 55: * --jpt-run=Win8394606Test > 56: */ > 57: public class Win8394606Test { Can we name test in generic way? Like `WinComponentIDsTest`. ------------- PR Review: https://git.openjdk.org/jdk/pull/33450#pullrequestreview-5606015087 PR Review Comment: https://git.openjdk.org/jdk/pull/33450#discussion_r4341790357 PR Review Comment: https://git.openjdk.org/jdk/pull/33450#discussion_r4342190549
