On Thu, 22 Oct 2026 13:52:26 GMT, Vicente Romero <[email protected]> wrote:

>> Fix for [JDK-8271623](https://bugs.openjdk.org/browse/JDK-8271623) 
>> introduced a sensible optimization: omitting the generation of enclosing 
>> instance fields for classes not using it. We have decided not to apply this 
>> optimization to value classes, as it could be problematic. See related 
>> discussion 
>> [here](https://mail.openjdk.org/archives/list/[email protected]/thread/DROHHBNWIWPQZMJOWUNJGKMJO76MO4FS/)
>> 
>> TIA
>> 
>> 
>> 
>> 
>> ---------
>> - [X] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Vicente Romero has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   review comment

Marked as reviewed by mcimadamore (Reviewer).

src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Lower.java line 2279:

> 2277:       }
> 2278:       if (sym.isValueClass()) {
> 2279:           // Class is value class

Maybe let's spell it out "omitting enclosing instance field in value classes 
changes =="

-------------

PR Review: https://git.openjdk.org/jdk/pull/33507#pullrequestreview-5617579932
PR Review Comment: https://git.openjdk.org/jdk/pull/33507#discussion_r4350906946

Reply via email to