> `CachedRowSetWriter` is searching for **where** clauses within SQL queries. 
> However, these UPDATE and SELECT queries are manually re-constructed, and 
> will not contain **where** at that point that the search occurs. Thus, both 
> occurrences of these checks are incorrect, and their associated comments are 
> misleading. They should be removed to prevent erroneous stripping when an 
> identifier, such as a table name, contains the substring "where".
> 
> Testing done with stub classes.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Justin Lu has updated the pull request incrementally with one additional commit 
since the last revision:

  Also check multiple row/col updates

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/33519/files
  - new: https://git.openjdk.org/jdk/pull/33519/files/b62084e0..06eb04fd

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=33519&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=33519&range=00-01

  Stats: 68 lines in 1 file changed: 47 ins; 13 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/33519.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/33519/head:pull/33519

PR: https://git.openjdk.org/jdk/pull/33519

Reply via email to