On Fri, 23 Oct 2026 08:26:01 GMT, Matthias Baesken <[email protected]> wrote:
>> When testing the gcc flag '-Wunused-macros' to warn about unused macros, a >> couple of unused macros have been reported by the compiler, that could be >> removed. >> >> https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunused-macros >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Matthias Baesken has updated the pull request incrementally with one > additional commit since the last revision: > > Remove unneeded stuff from OperatingSystemImpl.c Please revert ALL of these changes in the java.desktop module. Whilst there may be one or two that really could be removed this level of clean up goes much too far. - You are removing some from at least one 3rd party file - We have defines that correspond to 'enums' and having all of them seems perfectly fine even if some aren't used - Useful algorithms are being removed. If they need to be used in future .. it would be best if they are still there. ------------- PR Comment: https://git.openjdk.org/jdk/pull/33468#issuecomment-6373370884
