> Our ongoing audit flags that newly added code (and recently modified by > [JDK-8394802](https://bugs.openjdk.org/browse/JDK-8394802)) in Unsafe lacks > @ForceInline, like some of their siblings do. It is both a code discipline > issue, and potential performance roadbump if we somehow decide not to inline > through these methods. > > I marked methods that AFAICS end up calling `@IntrinsicCandidate`, so forcing > inlining for them pays off when we reach the intrinsic. > > Additional testing: > - [x] Eyeballing Valhalla additions to Unsafe, no other hits > - [x] Linux x86_64 server fastdebug, `java/lang/invoke compiler/unsafe` > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into JDK-8395827-unsafe-forceinline - A few more paths - Merge branch 'master' into JDK-8395827-unsafe-forceinline - Fix ------------- Changes: - all: https://git.openjdk.org/jdk/pull/33564/files - new: https://git.openjdk.org/jdk/pull/33564/files/bc808655..8a2e90f4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=33564&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=33564&range=00-01 Stats: 46 lines in 2 files changed: 40 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk/pull/33564.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/33564/head:pull/33564 PR: https://git.openjdk.org/jdk/pull/33564
