On Thu, 29 Oct 2026 17:01:41 GMT, Maurizio Cimadamore <[email protected]>
wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> src/java.base/share/classes/java/lang/foreign/ValueLayout.java line 128:
>
>> 126: * An integral value layout models an integral data type.
>> 127: * <p>
>> 128: * Values associated with {@linkplain OfIntegral integral} layouts
>
> This is the last sentence that doesn't 100% sit with me. I think here we
> should talk about integral layouts. E.g. start the new para by saying: "an
> integral value layout has a signedness, to model whether the value associated
> with the layout is signed or unsigned" (not too happy with the flow, but
> hopefully you get the idea).
Rephrased this to:
> Integral value layouts have a _signedness_. That is, they can be either
> _signed_ or _unsigned_ to reflect the signedness of the values they are
> associated with.
What do you think?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33417#discussion_r4417017910
