On Wed, 4 Nov 2026 09:07:29 GMT, Volkan Yazici <[email protected]> wrote:
>> Erik Gahlin has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use -1 to detect EOF
>
> test/jdk/jdk/jfr/event/io/TestRandomAccessFileReadLine.java line 51:
>
>> 49: System.out.println("Disabled: " + linesDisabled);
>> 50: if (!linesEnabled.equals(linesDisabled)) {
>> 51: throw new Exception("Expected same result from
>> RandomAccessFile::readLine with or without JFR");
>
> Nit: You may considering removing `println`'s and highlighting the problem
> only on the unhappy path:
>
>
> assertEquals(
> linesEnabled, linesDisabled,
> "Expected same result from RandomAccessFile::readLine with or without
> JFR");
>
>
> Either way, it is fine.
It makes debugging easier if it is kept in the happy path as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33637#discussion_r4466697146
