On Mon, 16 Nov 2026 23:29:09 GMT, Dean Long <[email protected]> wrote:

>> Vladimir Kozlov has updated the pull request with a new target base due to a 
>> merge or a rebase. The pull request now contains 10 commits:
>> 
>>  - Merge branch 'master' into 8393490
>>  - Revert JDK-8394484 changes
>>  - Revert some changes
>>  - Additional test run for StressStackOverflow.java
>>  - Continue investigate StressStackOverflow.java failure
>>  - Add diagnostic run to StressStackOverflow.java test
>>  - Remove duplicated code
>>  - Add check to all SR allocations
>>  - Merge branch 'master' into 8393490
>>  - 8393490: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out with 
>> -XX:CompileThresholdScaling=0.01
>
> So StressStackOverflow.java failure was because of JDK-8394484?

Thank you, @dean-long, for looking on this again.

> So StressStackOverflow.java failure was because of JDK-8394484?

It seems so. Codex says that my changes prevent elimination of allocation 
because the test has try/catch around it and that affects the size of the used 
stack.

> This looks good to me.

Thank you. I may need to do more changes later because codex thinks my 
condition in `ConnectionGraph::can_reduce_phi_check_inputs()` should also check 
references by safe points as changes do in 
`PhaseMacroExpand::can_eliminate_allocation()`. So I will continue work on this.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33197#issuecomment-6953509595

Reply via email to