On Tue, 17 Nov 2026 14:07:58 GMT, Raffaello Giulietti <[email protected]> 
wrote:

>> Joe Darcy has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Add test coverage.
>
> test/jdk/jdk/incubator/vector/BasicFloat16ArithTests.java line 649:
> 
>> 647:             // if the starting value is even; otherwise, it should 
>> round up.
>> 648:             float roundedBack    = valueOf( halfWay).floatValue();
>> 649:             float roundedBackNeg = valueOf(-halfWay).floatValue();
> 
> What are these locals good for? They don't seem to be used.

Fair point; they were a holdover from the original loop-over-all-Float16-values 
I copied from elsewhere in the test. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33392#discussion_r4603273046

Reply via email to