On Thu, 19 Nov 2026 11:12:51 GMT, Manuel Hässig <[email protected]> wrote:

>> Larry has updated the pull request incrementally with one additional commit 
>> since the last revision:
>> 
>>   8394825: Add jtreg test for non-temporal arraycopy
>
> test/hotspot/jtreg/compiler/arraycopy/TestArrayCopyNonTemporal.java line 46:
> 
>> 44:  *      -XX:ArrayCopyNonTemporalThreshold=65536
>> 45:  *      compiler.arraycopy.TestArrayCopyNonTemporal
>> 46:  */
> 
> Ideally, we'd like all of our tests to run on all possible platforms. 
> Further, this could also serve as an additional test for the AVX-512 path. I 
> would propose that this tests has multiple run statements with different 
> requirements:
>  1. An x64 AVX2 test run
>  2. An x64 AVX3 test run
>  3. An non-x64 test run
> 
> Lastly, please use the jtreg variable `${test.main.class}` instead of writing 
> the class manually. This avoids typos.

Thanks, done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33437#discussion_r4628257145

Reply via email to