On Thu, 19 Nov 2026 13:47:58 GMT, Fabian Meumertzheim <[email protected]> wrote:

>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Fabian Meumertzheim has refreshed the contents of this pull request, and 
> previous commits have been removed. The incremental views will show 
> differences compared to the previous content of the PR. The pull request 
> contains one new commit since the last revision:
> 
>   8397817: System.nanoTime() does not scale with the number of threads on 
> macOS

Looks fine but please add the suggested comment.

Thanks

src/hotspot/os/bsd/os_bsd.cpp line 846:

> 844: #ifdef AARCH64
> 845:   return now;
> 846: #else

Suggestion:

// On Aarch64 we trust the monotonicity of the time value. For x86_64 we ensure 
the time does not go backwards.
#ifdef AARCH64
  return now;
#else

-------------

Changes requested by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/33970#pullrequestreview-5983765256
PR Review Comment: https://git.openjdk.org/jdk/pull/33970#discussion_r4635411518

Reply via email to