On Thu, 19 Nov 2026 17:28:05 GMT, Markus Grönlund <[email protected]> wrote:

> Greetings,
> 
> ClassLoadingService records a class load during 
> ClassFileParser::fill_instance_klass(), before the parsed class has been 
> accepted into the class hierarchy.
> 
> Consequently, its counters include implementation artifacts that are not 
> newly loaded classes:
> 
> * Scratch classes created during redefinition and retransformation.
> * Discarded class definitions, such as losing candidates from competing 
> parallel class-loading attempts.
> 
> These artifacts are reclaimed without corresponding class-unload accounting. 
> The cumulative loaded-class count is therefore inflated, and the reported 
> currently loaded count can grow even when the underlying metadata is 
> reclaimed.
> This affects consumers such as ClassLoadingMXBean and JFR’s class-loading 
> statistics, potentially giving a false indication of a class leak.
> 
> Fix
> Move the tally into InstanceKlass::add_to_hierarchy(), where only accepted 
> classes enter the hierarchy. Remove the separate CDS load notification to 
> avoid double-counting, while preserving shared class counts through 
> in_aot_cache().
> 
> This corresponds to the actual installation of loaded classes, rather than 
> class-file parsing. 
> 
> Noticed while working on 
> [JDK-8392362](https://bugs.openjdk.org/browse/JDK-8392362)
> 
> Testing:
> 
> - tiers 1, 2, 3
> - jdk_svc
> - jdk_jfr
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

This seems reasonable for the regular parsed classes, but I also see:

./share/cds/lambdaFormInvokers.cpp:  result->add_to_hierarchy(THREAD);
./share/cds/lambdaProxyClassDictionary.cpp:  
lambda_ik->add_to_hierarchy(THREAD);


and wonder if it will also pick up things it should not?

-------------

PR Review: https://git.openjdk.org/jdk/pull/33973#pullrequestreview-5986191797

Reply via email to