> Hi All, > > On x86, C2 currently implements vector count trailing zeros using following > formula :- > > ` ctz(x) = width - clz((x - 1) & ~x) > ` > On targets supporting AVX-512 BITALG or AVX512_VPOPCNTDQ features , we can > use following shorter identity:- > > ` ctz(x) = popcount((x - 1) & ~x) > ` > This will enable `vpopcntb/w` for byte/short lanes and `vpopcntd/q` for > int/long lanes. Existing lowering should remain as the fallback when these > CPU features are unavailable. > > Following are the performance number of benchmark included with the patch. > > > System: AMD EPYC 9755 128-Core Processor (Turin) Fixed frequency 2.5Ghz > > Baseline:- > ---------- > Benchmark Mode Cnt Score > Error Units > VectorCountTrailingZerosBenchmark.byteThroughput thrpt 2 569.742 > ops/us > VectorCountTrailingZerosBenchmark.intThroughput thrpt 2 1378.783 > ops/us > VectorCountTrailingZerosBenchmark.longThroughput thrpt 2 1154.720 > ops/us > VectorCountTrailingZerosBenchmark.shortThroughput thrpt 2 717.462 > ops/us > VectorCountTrailingZerosBenchmark.byteLatency avgt 2 7.848 > ns/op > VectorCountTrailingZerosBenchmark.intLatency avgt 2 3.328 > ns/op > VectorCountTrailingZerosBenchmark.longLatency avgt 2 3.284 > ns/op > VectorCountTrailingZerosBenchmark.shortLatency avgt 2 5.017 > ns/op > > Withopt:- > ---------- > Benchmark Mode Cnt Score > Error Units > VectorCountTrailingZerosBenchmark.byteThroughput thrpt 2 1174.785 > ops/us > VectorCountTrailingZerosBenchmark.intThroughput thrpt 2 1600.252 > ops/us > VectorCountTrailingZerosBenchmark.longThroughput thrpt 2 1396.755 > ops/us > VectorCountTrailingZerosBenchmark.shortThroughput thrpt 2 1193.041 > ops/us > VectorCountTrailingZerosBenchmark.byteLatency avgt 2 2.352 > ns/op > VectorCountTrailingZerosBenchmark.intLatency avgt 2 2.344 > ns/op > VectorCountTrailingZerosBenchmark.longLatency avgt 2 2.345 > ns/op > VectorCountTrailingZerosBenchmark.shortLatency avgt 2 2.338 > ns/op > > > Kindly review and share your feedback. > > Best Regards, > Jatin > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
Jatin Bhateja has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8393511 - Review comments resolution - Adding comments - 8393511: Optimize x86 vector count trailing zeros using popcount instructions ------------- Changes: - all: https://git.openjdk.org/jdk/pull/33863/files - new: https://git.openjdk.org/jdk/pull/33863/files/db039082..36c4be52 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=33863&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=33863&range=00-01 Stats: 31939 lines in 879 files changed: 19250 ins; 3928 del; 8761 mod Patch: https://git.openjdk.org/jdk/pull/33863.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/33863/head:pull/33863 PR: https://git.openjdk.org/jdk/pull/33863
