On Fri, 20 Nov 2026 16:29:26 GMT, Ashay Rane <[email protected]> wrote:
> Tangentially related, short of pinging specific people, is there a process > for soliciting reviews? I ask because at-mentioning individual people (often > times, subsystem maintainers, who are understandably busy) seems too > invasive. Well, that's what you have to do. > The alternative seems to be to wait until someone (especially a capital-r > Reviewer) notices, but I've seen months go by. Is there a middle ground that > I am forgetting/missing? That's a tough question to answer. It all depends on how hard a PR is to review. Some are an easy no or yes, but some are hard. Speaking for myself, it depends on how confident I am. In this case, the PR touches a number of different areas, some of which I am expert in, and some of which (e.g. Windows) I don't know at all. While I am "legally" allowed to review Windows PRs, that doesn't mean I should. Also, people don't always make things easy for reviewers. In this one, for example, I had to ask for a reference to Arm documentation without which the code was very hard to review. Here, we need at least one Windows reviewer. I'll approve the AArch64 part. ------------- PR Comment: https://git.openjdk.org/jdk/pull/33595#issuecomment-7061023552
