On Wed, 14 Oct 2026 11:39:54 GMT, Maurizio Cimadamore <[email protected]> wrote:
>> Liam Miller-Cushon has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains 13 >> additional commits since the last revision: >> >> - Clean up unused import >> - Merge remote-tracking branch 'origin/master' into short-vector >> - Move asReadOnlyMemorySegment to String >> - Add a benchmark >> >> Also adjust javadoc, convert test to JUnit 5, other small adjustments >> - javadoc >> - Move access to jdk.internal.foreign.StringSupport >> - Make test inputs longer >> - Test coverage >> - Move to X-Vector.java.template, update javadoc, add masked overloads >> - ShortVector.compatibleWith >> - ... and 3 more: https://git.openjdk.org/jdk/compare/e671a459...1c6ff6ab > > src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java > line 3809: > >> 3807: * code units in the specified {@link Charset}} >> 3808: * >> 3809: * <p>This method runs in constant time, and is intended to be >> used as a guard for > > Perhaps better to separate a bit -- the fact that this runs in constant time > seems more of an implNote. But maybe providing an example of how this might > be used could help (e.g. show the "if" and then the call) (`compatibleWith` is gone in the latest version) > src/jdk.incubator.vector/share/classes/jdk/incubator/vector/ByteVector.java > line 3814: > >> 3812: * @param string the string >> 3813: * @param charset the charset representing the 8-bit character >> encoding >> 3814: * @throws NullPointerException if {@code string} or {@code >> charset} is {@code null} > > Not needed -- the package-info already says that "unless otherwise > specified... every method throws NPE" Thanks, I removed redundant `@throws NullPointerException` ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32373#discussion_r4652493630 PR Review Comment: https://git.openjdk.org/jdk/pull/32373#discussion_r4652494537
