On 20 June 2017 at 11:55, Brett Cannon <br...@python.org> wrote: > On Mon, Jun 19, 2017, 18:15 Nick Coghlan, <ncogh...@gmail.com> wrote: >> "Awaiting changes" -> "Awaiting merge": Core dev implements changes > > > They could change their review to handle this.
True. >> Core dev PR -> "Awaiting changes" > > If this is due to a review from a core dev then it's just like any other > core review as you don't want to ignore such a review. True, but I was thinking of the "WIP" case - GitHub doesn't let you review your own PRs, so you can't give yourself a negative review to indicate that the PR is incomplete. However, setting "Awaiting changes" explicitly will work fine. Cheers, Nick. -- Nick Coghlan | ncogh...@gmail.com | Brisbane, Australia _______________________________________________ core-workflow mailing list core-workflow@python.org https://mail.python.org/mailman/listinfo/core-workflow This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct
