> -----Original Message----- > From: Carl-Daniel Hailfinger [mailto:[EMAIL PROTECTED] > Sent: Thursday, November 06, 2008 3:36 AM > To: coreboot@coreboot.org; Myles Watson; ron minnich > Subject: Re: [coreboot] r983 - in coreboot-v3: device include/device > > Hi Myles, > > I'm sorry I didn't have time to review your patch a bit sooner. > AFAICS it introduced a few bugs regarding conditional compilation. > Review follows. >
Whoa. You're right. I guess it's the same as it was, since it was never compiled in before either. It brings up the interesting question of how this should work, since if you try to compile in that support it breaks because it can't find the default ops structures. Should there be a table of default ops somewhere? How do we compile in support for plug ins? Thanks, Myles -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
