On 06.11.2008 14:26, Myles Watson wrote: > >> -----Original Message----- >> From: Carl-Daniel Hailfinger [mailto:[EMAIL PROTECTED] >> Sent: Thursday, November 06, 2008 3:36 AM >> To: coreboot@coreboot.org; Myles Watson; ron minnich >> Subject: Re: [coreboot] r983 - in coreboot-v3: device include/device >> >> Hi Myles, >> >> I'm sorry I didn't have time to review your patch a bit sooner. >> AFAICS it introduced a few bugs regarding conditional compilation. >> Review follows. >> >> > > Whoa. You're right. I guess it's the same as it was, since it was never > compiled in before either. > > It brings up the interesting question of how this should work, since if you > try to compile in that support it breaks because it can't find the default > ops structures. >
I believe that's why the original code had this: /* We should move these so they're really config options */ #define CONFIG_HYPERTRANSPORT_PLUGIN_SUPPORT 0 #define CONFIG_PCIX_PLUGIN_SUPPORT 0 #define CONFIG_PCIE_PLUGIN_SUPPORT 0 #define CONFIG_CARDBUS_PLUGIN_SUPPORT 0 #define CONFIG_AGP_PLUGIN_SUPPORT 0 Had these been made real config options instead of being dropped, everything should have worked. > Should there be a table of default ops somewhere? How do we compile in > support for plug ins? > See above. Regards, Carl-Daniel -- http://www.hailfinger.org/ -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot