Hi,
Please find the latest report on new defect(s) introduced to coreboot found
with Coverity Scan.
7 new defect(s) introduced to coreboot found with Coverity Scan.
5 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 7 of 7 defect(s)
** CID 1401344: (OVERRUN)
________________________________________________________________________________________________________
*** CID 1401344: (OVERRUN)
/src/mainboard/intel/kunimitsu/romstage.c: 34 in mainboard_memory_init_params()
28
29 void mainboard_memory_init_params(struct romstage_params *params,
30 MEMORY_INIT_UPD *memory_params)
31 {
32 spd_memory_init_params(memory_params);
33 mainboard_fill_dq_map_data(&memory_params->DqByteMapCh0);
>>> CID 1401344: (OVERRUN)
>>> Overrunning array "memory_params->DqsMapCpu2DramCh0" of 8 bytes by
>>> passing it to a function which accesses it at byte offset 15.
34 mainboard_fill_dqs_map_data(&memory_params->DqsMapCpu2DramCh0);
35 mainboard_fill_rcomp_res_data(&memory_params->RcompResistor);
36 mainboard_fill_rcomp_strength_data(&memory_params->RcompTarget);
37 memory_params->MemorySpdDataLen = SPD_LEN;
38 memory_params->DqPinsInterleaved = FALSE;
/src/mainboard/intel/saddlebrook/romstage.c: 67 in
mainboard_memory_init_params()
61 /*
62 * Configure the DQ/DQS settings if required. In general the settings
63 * should be set in the FSP flash image and should not need to be
64 * changed.
65 */
66 mainboard_fill_dq_map_data(&memory_params->DqByteMapCh0);
>>> CID 1401344: (OVERRUN)
>>> Overrunning array "memory_params->DqsMapCpu2DramCh0" of 8 bytes by
>>> passing it to a function which accesses it at byte offset 15.
67 mainboard_fill_dqs_map_data(&memory_params->DqsMapCpu2DramCh0);
68 mainboard_fill_rcomp_res_data(&memory_params->RcompResistor);
69 mainboard_fill_rcomp_strength_data(&memory_params->RcompTarget);
70
71 /* update spd length*/
72 memory_params->MemorySpdDataLen = blk.len;
73 memory_params->DqPinsInterleaved = TRUE;
** CID 1401343: Memory - corruptions (OVERRUN)
/src/mainboard/google/glados/variants/lars/variant.c: 63 in
variant_memory_init_params()
________________________________________________________________________________________________________
*** CID 1401343: Memory - corruptions (OVERRUN)
/src/mainboard/google/glados/variants/lars/variant.c: 63 in
variant_memory_init_params()
57 /* Override Rcomp Target assignment for specific SKU(s) */
58 if (spd_index == K4E6E304EB_MEM_ID)
59 targeted_rcomp = StrengthendRcompTarget;
60
61 memcpy(params->DqByteMapCh0, dq_map,
62 sizeof(params->DqByteMapCh0) * 2);
>>> CID 1401343: Memory - corruptions (OVERRUN)
>>> Overrunning array "params->DqsMapCpu2DramCh0" of 8 bytes by passing it
>>> to a function which accesses it at byte offset 15 using argument "16UL".
>>> [Note: The source code implementation of the function has been overridden
>>> by a builtin model.]
63 memcpy(params->DqsMapCpu2DramCh0, dqs_map,
64 sizeof(params->DqsMapCpu2DramCh0) * 2);
65 memcpy(params->RcompResistor, RcompResistor,
66 sizeof(params->RcompResistor));
67 memcpy(params->RcompTarget, targeted_rcomp,
68 sizeof(params->RcompTarget));
** CID 1401342: (BUFFER_SIZE)
/src/mainboard/google/glados/variants/caroline/variant.c: 44 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/caroline/variant.c: 46 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/glados/variant.c: 44 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/glados/variant.c: 46 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/chell/variant.c: 44 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/chell/variant.c: 46 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/cave/variant.c: 44 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/cave/variant.c: 46 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/lars/variant.c: 61 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/lars/variant.c: 63 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/asuka/variant.c: 42 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/asuka/variant.c: 44 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/sentry/variant.c: 54 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/sentry/variant.c: 56 in
variant_memory_init_params()
________________________________________________________________________________________________________
*** CID 1401342: (BUFFER_SIZE)
/src/mainboard/google/glados/variants/caroline/variant.c: 44 in
variant_memory_init_params()
38 /* Rcomp resistor */
39 const u16 RcompResistor[3] = { 200, 81, 162 };
40
41 /* Rcomp target */
42 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
43
>>> CID 1401342: (BUFFER_SIZE)
>>> You might overrun the 12 byte destination string
>>> "memory_params->DqByteMapCh0" by writing the maximum 24 bytes from "dq_map".
44 memcpy(memory_params->DqByteMapCh0, dq_map,
45 sizeof(memory_params->DqByteMapCh0) * 2);
46 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
47 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
48 memcpy(memory_params->RcompResistor, RcompResistor,
49 sizeof(memory_params->RcompResistor));
/src/mainboard/google/glados/variants/caroline/variant.c: 46 in
variant_memory_init_params()
40
41 /* Rcomp target */
42 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
43
44 memcpy(memory_params->DqByteMapCh0, dq_map,
45 sizeof(memory_params->DqByteMapCh0) * 2);
>>> CID 1401342: (BUFFER_SIZE)
>>> You might overrun the 8 byte destination string
>>> "memory_params->DqsMapCpu2DramCh0" by writing the maximum 16 bytes from
>>> "dqs_map".
46 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
47 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
48 memcpy(memory_params->RcompResistor, RcompResistor,
49 sizeof(memory_params->RcompResistor));
50 memcpy(memory_params->RcompTarget, RcompTarget,
51 sizeof(memory_params->RcompTarget));
/src/mainboard/google/glados/variants/glados/variant.c: 44 in
variant_memory_init_params()
38 /* Rcomp resistor */
39 const u16 RcompResistor[3] = { 200, 81, 162 };
40
41 /* Rcomp target */
42 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
43
>>> CID 1401342: (BUFFER_SIZE)
>>> You might overrun the 12 byte destination string
>>> "memory_params->DqByteMapCh0" by writing the maximum 24 bytes from "dq_map".
44 memcpy(memory_params->DqByteMapCh0, dq_map,
45 sizeof(memory_params->DqByteMapCh0) * 2);
46 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
47 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
48 memcpy(memory_params->RcompResistor, RcompResistor,
49 sizeof(memory_params->RcompResistor));
/src/mainboard/google/glados/variants/glados/variant.c: 46 in
variant_memory_init_params()
40
41 /* Rcomp target */
42 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
43
44 memcpy(memory_params->DqByteMapCh0, dq_map,
45 sizeof(memory_params->DqByteMapCh0) * 2);
>>> CID 1401342: (BUFFER_SIZE)
>>> You might overrun the 8 byte destination string
>>> "memory_params->DqsMapCpu2DramCh0" by writing the maximum 16 bytes from
>>> "dqs_map".
46 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
47 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
48 memcpy(memory_params->RcompResistor, RcompResistor,
49 sizeof(memory_params->RcompResistor));
50 memcpy(memory_params->RcompTarget, RcompTarget,
51 sizeof(memory_params->RcompTarget));
/src/mainboard/google/glados/variants/chell/variant.c: 44 in
variant_memory_init_params()
38 /* Rcomp resistor */
39 const u16 RcompResistor[3] = { 200, 81, 162 };
40
41 /* Rcomp target */
42 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
43
>>> CID 1401342: (BUFFER_SIZE)
>>> You might overrun the 12 byte destination string
>>> "memory_params->DqByteMapCh0" by writing the maximum 24 bytes from "dq_map".
44 memcpy(memory_params->DqByteMapCh0, dq_map,
45 sizeof(memory_params->DqByteMapCh0) * 2);
46 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
47 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
48 memcpy(memory_params->RcompResistor, RcompResistor,
49 sizeof(memory_params->RcompResistor));
/src/mainboard/google/glados/variants/chell/variant.c: 46 in
variant_memory_init_params()
40
41 /* Rcomp target */
42 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
43
44 memcpy(memory_params->DqByteMapCh0, dq_map,
45 sizeof(memory_params->DqByteMapCh0) * 2);
>>> CID 1401342: (BUFFER_SIZE)
>>> You might overrun the 8 byte destination string
>>> "memory_params->DqsMapCpu2DramCh0" by writing the maximum 16 bytes from
>>> "dqs_map".
46 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
47 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
48 memcpy(memory_params->RcompResistor, RcompResistor,
49 sizeof(memory_params->RcompResistor));
50 memcpy(memory_params->RcompTarget, RcompTarget,
51 sizeof(memory_params->RcompTarget));
/src/mainboard/google/glados/variants/cave/variant.c: 44 in
variant_memory_init_params()
38 /* Rcomp resistor */
39 const u16 RcompResistor[3] = { 200, 81, 162 };
40
41 /* Rcomp target */
42 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
43
>>> CID 1401342: (BUFFER_SIZE)
>>> You might overrun the 12 byte destination string
>>> "memory_params->DqByteMapCh0" by writing the maximum 24 bytes from "dq_map".
44 memcpy(memory_params->DqByteMapCh0, dq_map,
45 sizeof(memory_params->DqByteMapCh0) * 2);
46 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
47 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
48 memcpy(memory_params->RcompResistor, RcompResistor,
49 sizeof(memory_params->RcompResistor));
/src/mainboard/google/glados/variants/cave/variant.c: 46 in
variant_memory_init_params()
40
41 /* Rcomp target */
42 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
43
44 memcpy(memory_params->DqByteMapCh0, dq_map,
45 sizeof(memory_params->DqByteMapCh0) * 2);
>>> CID 1401342: (BUFFER_SIZE)
>>> You might overrun the 8 byte destination string
>>> "memory_params->DqsMapCpu2DramCh0" by writing the maximum 16 bytes from
>>> "dqs_map".
46 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
47 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
48 memcpy(memory_params->RcompResistor, RcompResistor,
49 sizeof(memory_params->RcompResistor));
50 memcpy(memory_params->RcompTarget, RcompTarget,
51 sizeof(memory_params->RcompTarget));
/src/mainboard/google/glados/variants/lars/variant.c: 61 in
variant_memory_init_params()
55 const u16 *targeted_rcomp = RcompTarget;
56
57 /* Override Rcomp Target assignment for specific SKU(s) */
58 if (spd_index == K4E6E304EB_MEM_ID)
59 targeted_rcomp = StrengthendRcompTarget;
60
>>> CID 1401342: (BUFFER_SIZE)
>>> You might overrun the 12 byte destination string "params->DqByteMapCh0"
>>> by writing the maximum 24 bytes from "dq_map".
61 memcpy(params->DqByteMapCh0, dq_map,
62 sizeof(params->DqByteMapCh0) * 2);
63 memcpy(params->DqsMapCpu2DramCh0, dqs_map,
64 sizeof(params->DqsMapCpu2DramCh0) * 2);
65 memcpy(params->RcompResistor, RcompResistor,
66 sizeof(params->RcompResistor));
/src/mainboard/google/glados/variants/lars/variant.c: 63 in
variant_memory_init_params()
57 /* Override Rcomp Target assignment for specific SKU(s) */
58 if (spd_index == K4E6E304EB_MEM_ID)
59 targeted_rcomp = StrengthendRcompTarget;
60
61 memcpy(params->DqByteMapCh0, dq_map,
62 sizeof(params->DqByteMapCh0) * 2);
>>> CID 1401342: (BUFFER_SIZE)
>>> You might overrun the 8 byte destination string
>>> "params->DqsMapCpu2DramCh0" by writing the maximum 16 bytes from "dqs_map".
63 memcpy(params->DqsMapCpu2DramCh0, dqs_map,
64 sizeof(params->DqsMapCpu2DramCh0) * 2);
65 memcpy(params->RcompResistor, RcompResistor,
66 sizeof(params->RcompResistor));
67 memcpy(params->RcompTarget, targeted_rcomp,
68 sizeof(params->RcompTarget));
/src/mainboard/google/glados/variants/asuka/variant.c: 42 in
variant_memory_init_params()
36 /* Rcomp resistor */
37 const u16 RcompResistor[3] = { 200, 81, 162 };
38
39 /* Rcomp target */
40 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
41
>>> CID 1401342: (BUFFER_SIZE)
>>> You might overrun the 12 byte destination string
>>> "memory_params->DqByteMapCh0" by writing the maximum 24 bytes from "dq_map".
42 memcpy(memory_params->DqByteMapCh0, dq_map,
43 sizeof(memory_params->DqByteMapCh0) * 2);
44 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
45 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
46 memcpy(memory_params->RcompResistor, RcompResistor,
47 sizeof(memory_params->RcompResistor));
/src/mainboard/google/glados/variants/asuka/variant.c: 44 in
variant_memory_init_params()
38
39 /* Rcomp target */
40 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
41
42 memcpy(memory_params->DqByteMapCh0, dq_map,
43 sizeof(memory_params->DqByteMapCh0) * 2);
>>> CID 1401342: (BUFFER_SIZE)
>>> You might overrun the 8 byte destination string
>>> "memory_params->DqsMapCpu2DramCh0" by writing the maximum 16 bytes from
>>> "dqs_map".
44 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
45 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
46 memcpy(memory_params->RcompResistor, RcompResistor,
47 sizeof(memory_params->RcompResistor));
48 memcpy(memory_params->RcompTarget, RcompTarget,
49 sizeof(memory_params->RcompTarget));
/src/mainboard/google/glados/variants/sentry/variant.c: 54 in
variant_memory_init_params()
48 const u16 *targeted_rcomp = RcompTarget;
49
50 /* Override Rcomp Target assignment for specific SKU(s) */
51 if (spd_index == K4E6E304EE_MEM_ID)
52 targeted_rcomp = StrengthendRcompTarget;
53
>>> CID 1401342: (BUFFER_SIZE)
>>> You might overrun the 12 byte destination string
>>> "memory_params->DqByteMapCh0" by writing the maximum 24 bytes from "dq_map".
54 memcpy(memory_params->DqByteMapCh0, dq_map,
55 sizeof(memory_params->DqByteMapCh0) * 2);
56 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
57 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
58 memcpy(memory_params->RcompResistor, RcompResistor,
59 sizeof(memory_params->RcompResistor));
60 memcpy(memory_params->RcompTarget, targeted_rcomp,
61 sizeof(memory_params->RcompTarget));
/src/mainboard/google/glados/variants/sentry/variant.c: 56 in
variant_memory_init_params()
50 /* Override Rcomp Target assignment for specific SKU(s) */
51 if (spd_index == K4E6E304EE_MEM_ID)
52 targeted_rcomp = StrengthendRcompTarget;
53
54 memcpy(memory_params->DqByteMapCh0, dq_map,
55 sizeof(memory_params->DqByteMapCh0) * 2);
>>> CID 1401342: (BUFFER_SIZE)
>>> You might overrun the 8 byte destination string
>>> "memory_params->DqsMapCpu2DramCh0" by writing the maximum 16 bytes from
>>> "dqs_map".
56 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
57 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
58 memcpy(memory_params->RcompResistor, RcompResistor,
59 sizeof(memory_params->RcompResistor));
60 memcpy(memory_params->RcompTarget, targeted_rcomp,
61 sizeof(memory_params->RcompTarget));
** CID 1401341: (OVERRUN)
________________________________________________________________________________________________________
*** CID 1401341: (OVERRUN)
/src/mainboard/intel/kunimitsu/romstage.c: 33 in mainboard_memory_init_params()
27 }
28
29 void mainboard_memory_init_params(struct romstage_params *params,
30 MEMORY_INIT_UPD *memory_params)
31 {
32 spd_memory_init_params(memory_params);
>>> CID 1401341: (OVERRUN)
>>> Overrunning array "memory_params->DqByteMapCh0" of 12 bytes by passing
>>> it to a function which accesses it at byte offset 23.
33 mainboard_fill_dq_map_data(&memory_params->DqByteMapCh0);
34 mainboard_fill_dqs_map_data(&memory_params->DqsMapCpu2DramCh0);
35 mainboard_fill_rcomp_res_data(&memory_params->RcompResistor);
36 mainboard_fill_rcomp_strength_data(&memory_params->RcompTarget);
37 memory_params->MemorySpdDataLen = SPD_LEN;
38 memory_params->DqPinsInterleaved = FALSE;
/src/mainboard/intel/saddlebrook/romstage.c: 66 in
mainboard_memory_init_params()
60
61 /*
62 * Configure the DQ/DQS settings if required. In general the settings
63 * should be set in the FSP flash image and should not need to be
64 * changed.
65 */
>>> CID 1401341: (OVERRUN)
>>> Overrunning array "memory_params->DqByteMapCh0" of 12 bytes by passing
>>> it to a function which accesses it at byte offset 23.
66 mainboard_fill_dq_map_data(&memory_params->DqByteMapCh0);
67 mainboard_fill_dqs_map_data(&memory_params->DqsMapCpu2DramCh0);
68 mainboard_fill_rcomp_res_data(&memory_params->RcompResistor);
69 mainboard_fill_rcomp_strength_data(&memory_params->RcompTarget);
70
71 /* update spd length*/
72 memory_params->MemorySpdDataLen = blk.len;
73 memory_params->DqPinsInterleaved = TRUE;
** CID 1401340: Memory - corruptions (OVERRUN)
/src/mainboard/google/glados/variants/lars/variant.c: 61 in
variant_memory_init_params()
________________________________________________________________________________________________________
*** CID 1401340: Memory - corruptions (OVERRUN)
/src/mainboard/google/glados/variants/lars/variant.c: 61 in
variant_memory_init_params()
55 const u16 *targeted_rcomp = RcompTarget;
56
57 /* Override Rcomp Target assignment for specific SKU(s) */
58 if (spd_index == K4E6E304EB_MEM_ID)
59 targeted_rcomp = StrengthendRcompTarget;
60
>>> CID 1401340: Memory - corruptions (OVERRUN)
>>> Overrunning array "params->DqByteMapCh0" of 12 bytes by passing it to a
>>> function which accesses it at byte offset 23 using argument "24UL". [Note:
>>> The source code implementation of the function has been overridden by a
>>> builtin model.]
61 memcpy(params->DqByteMapCh0, dq_map,
62 sizeof(params->DqByteMapCh0) * 2);
63 memcpy(params->DqsMapCpu2DramCh0, dqs_map,
64 sizeof(params->DqsMapCpu2DramCh0) * 2);
65 memcpy(params->RcompResistor, RcompResistor,
66 sizeof(params->RcompResistor));
** CID 1401339: (OVERRUN)
/src/mainboard/google/glados/variants/caroline/variant.c: 46 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/glados/variant.c: 46 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/chell/variant.c: 46 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/cave/variant.c: 46 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/asuka/variant.c: 44 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/sentry/variant.c: 56 in
variant_memory_init_params()
________________________________________________________________________________________________________
*** CID 1401339: (OVERRUN)
/src/mainboard/google/glados/variants/caroline/variant.c: 46 in
variant_memory_init_params()
40
41 /* Rcomp target */
42 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
43
44 memcpy(memory_params->DqByteMapCh0, dq_map,
45 sizeof(memory_params->DqByteMapCh0) * 2);
>>> CID 1401339: (OVERRUN)
>>> Overrunning array "memory_params->DqsMapCpu2DramCh0" of 8 bytes by
>>> passing it to a function which accesses it at byte offset 15 using argument
>>> "16UL". [Note: The source code implementation of the function has been
>>> overridden by a builtin model.]
46 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
47 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
48 memcpy(memory_params->RcompResistor, RcompResistor,
49 sizeof(memory_params->RcompResistor));
50 memcpy(memory_params->RcompTarget, RcompTarget,
51 sizeof(memory_params->RcompTarget));
/src/mainboard/google/glados/variants/glados/variant.c: 46 in
variant_memory_init_params()
40
41 /* Rcomp target */
42 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
43
44 memcpy(memory_params->DqByteMapCh0, dq_map,
45 sizeof(memory_params->DqByteMapCh0) * 2);
>>> CID 1401339: (OVERRUN)
>>> Overrunning array "memory_params->DqsMapCpu2DramCh0" of 8 bytes by
>>> passing it to a function which accesses it at byte offset 15 using argument
>>> "16UL". [Note: The source code implementation of the function has been
>>> overridden by a builtin model.]
46 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
47 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
48 memcpy(memory_params->RcompResistor, RcompResistor,
49 sizeof(memory_params->RcompResistor));
50 memcpy(memory_params->RcompTarget, RcompTarget,
51 sizeof(memory_params->RcompTarget));
/src/mainboard/google/glados/variants/chell/variant.c: 46 in
variant_memory_init_params()
40
41 /* Rcomp target */
42 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
43
44 memcpy(memory_params->DqByteMapCh0, dq_map,
45 sizeof(memory_params->DqByteMapCh0) * 2);
>>> CID 1401339: (OVERRUN)
>>> Overrunning array "memory_params->DqsMapCpu2DramCh0" of 8 bytes by
>>> passing it to a function which accesses it at byte offset 15 using argument
>>> "16UL". [Note: The source code implementation of the function has been
>>> overridden by a builtin model.]
46 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
47 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
48 memcpy(memory_params->RcompResistor, RcompResistor,
49 sizeof(memory_params->RcompResistor));
50 memcpy(memory_params->RcompTarget, RcompTarget,
51 sizeof(memory_params->RcompTarget));
/src/mainboard/google/glados/variants/cave/variant.c: 46 in
variant_memory_init_params()
40
41 /* Rcomp target */
42 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
43
44 memcpy(memory_params->DqByteMapCh0, dq_map,
45 sizeof(memory_params->DqByteMapCh0) * 2);
>>> CID 1401339: (OVERRUN)
>>> Overrunning array "memory_params->DqsMapCpu2DramCh0" of 8 bytes by
>>> passing it to a function which accesses it at byte offset 15 using argument
>>> "16UL". [Note: The source code implementation of the function has been
>>> overridden by a builtin model.]
46 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
47 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
48 memcpy(memory_params->RcompResistor, RcompResistor,
49 sizeof(memory_params->RcompResistor));
50 memcpy(memory_params->RcompTarget, RcompTarget,
51 sizeof(memory_params->RcompTarget));
/src/mainboard/google/glados/variants/asuka/variant.c: 44 in
variant_memory_init_params()
38
39 /* Rcomp target */
40 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
41
42 memcpy(memory_params->DqByteMapCh0, dq_map,
43 sizeof(memory_params->DqByteMapCh0) * 2);
>>> CID 1401339: (OVERRUN)
>>> Overrunning array "memory_params->DqsMapCpu2DramCh0" of 8 bytes by
>>> passing it to a function which accesses it at byte offset 15 using argument
>>> "16UL". [Note: The source code implementation of the function has been
>>> overridden by a builtin model.]
44 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
45 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
46 memcpy(memory_params->RcompResistor, RcompResistor,
47 sizeof(memory_params->RcompResistor));
48 memcpy(memory_params->RcompTarget, RcompTarget,
49 sizeof(memory_params->RcompTarget));
/src/mainboard/google/glados/variants/sentry/variant.c: 56 in
variant_memory_init_params()
50 /* Override Rcomp Target assignment for specific SKU(s) */
51 if (spd_index == K4E6E304EE_MEM_ID)
52 targeted_rcomp = StrengthendRcompTarget;
53
54 memcpy(memory_params->DqByteMapCh0, dq_map,
55 sizeof(memory_params->DqByteMapCh0) * 2);
>>> CID 1401339: (OVERRUN)
>>> Overrunning array "memory_params->DqsMapCpu2DramCh0" of 8 bytes by
>>> passing it to a function which accesses it at byte offset 15 using argument
>>> "16UL". [Note: The source code implementation of the function has been
>>> overridden by a builtin model.]
56 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
57 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
58 memcpy(memory_params->RcompResistor, RcompResistor,
59 sizeof(memory_params->RcompResistor));
60 memcpy(memory_params->RcompTarget, targeted_rcomp,
61 sizeof(memory_params->RcompTarget));
** CID 1401338: (OVERRUN)
/src/mainboard/google/glados/variants/caroline/variant.c: 44 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/glados/variant.c: 44 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/chell/variant.c: 44 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/cave/variant.c: 44 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/asuka/variant.c: 42 in
variant_memory_init_params()
/src/mainboard/google/glados/variants/sentry/variant.c: 54 in
variant_memory_init_params()
________________________________________________________________________________________________________
*** CID 1401338: (OVERRUN)
/src/mainboard/google/glados/variants/caroline/variant.c: 44 in
variant_memory_init_params()
38 /* Rcomp resistor */
39 const u16 RcompResistor[3] = { 200, 81, 162 };
40
41 /* Rcomp target */
42 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
43
>>> CID 1401338: (OVERRUN)
>>> Overrunning array "memory_params->DqByteMapCh0" of 12 bytes by passing
>>> it to a function which accesses it at byte offset 23 using argument "24UL".
>>> [Note: The source code implementation of the function has been overridden
>>> by a builtin model.]
44 memcpy(memory_params->DqByteMapCh0, dq_map,
45 sizeof(memory_params->DqByteMapCh0) * 2);
46 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
47 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
48 memcpy(memory_params->RcompResistor, RcompResistor,
49 sizeof(memory_params->RcompResistor));
/src/mainboard/google/glados/variants/glados/variant.c: 44 in
variant_memory_init_params()
38 /* Rcomp resistor */
39 const u16 RcompResistor[3] = { 200, 81, 162 };
40
41 /* Rcomp target */
42 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
43
>>> CID 1401338: (OVERRUN)
>>> Overrunning array "memory_params->DqByteMapCh0" of 12 bytes by passing
>>> it to a function which accesses it at byte offset 23 using argument "24UL".
>>> [Note: The source code implementation of the function has been overridden
>>> by a builtin model.]
44 memcpy(memory_params->DqByteMapCh0, dq_map,
45 sizeof(memory_params->DqByteMapCh0) * 2);
46 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
47 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
48 memcpy(memory_params->RcompResistor, RcompResistor,
49 sizeof(memory_params->RcompResistor));
/src/mainboard/google/glados/variants/chell/variant.c: 44 in
variant_memory_init_params()
38 /* Rcomp resistor */
39 const u16 RcompResistor[3] = { 200, 81, 162 };
40
41 /* Rcomp target */
42 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
43
>>> CID 1401338: (OVERRUN)
>>> Overrunning array "memory_params->DqByteMapCh0" of 12 bytes by passing
>>> it to a function which accesses it at byte offset 23 using argument "24UL".
>>> [Note: The source code implementation of the function has been overridden
>>> by a builtin model.]
44 memcpy(memory_params->DqByteMapCh0, dq_map,
45 sizeof(memory_params->DqByteMapCh0) * 2);
46 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
47 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
48 memcpy(memory_params->RcompResistor, RcompResistor,
49 sizeof(memory_params->RcompResistor));
/src/mainboard/google/glados/variants/cave/variant.c: 44 in
variant_memory_init_params()
38 /* Rcomp resistor */
39 const u16 RcompResistor[3] = { 200, 81, 162 };
40
41 /* Rcomp target */
42 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
43
>>> CID 1401338: (OVERRUN)
>>> Overrunning array "memory_params->DqByteMapCh0" of 12 bytes by passing
>>> it to a function which accesses it at byte offset 23 using argument "24UL".
>>> [Note: The source code implementation of the function has been overridden
>>> by a builtin model.]
44 memcpy(memory_params->DqByteMapCh0, dq_map,
45 sizeof(memory_params->DqByteMapCh0) * 2);
46 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
47 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
48 memcpy(memory_params->RcompResistor, RcompResistor,
49 sizeof(memory_params->RcompResistor));
/src/mainboard/google/glados/variants/asuka/variant.c: 42 in
variant_memory_init_params()
36 /* Rcomp resistor */
37 const u16 RcompResistor[3] = { 200, 81, 162 };
38
39 /* Rcomp target */
40 const u16 RcompTarget[5] = { 100, 40, 40, 23, 40 };
41
>>> CID 1401338: (OVERRUN)
>>> Overrunning array "memory_params->DqByteMapCh0" of 12 bytes by passing
>>> it to a function which accesses it at byte offset 23 using argument "24UL".
>>> [Note: The source code implementation of the function has been overridden
>>> by a builtin model.]
42 memcpy(memory_params->DqByteMapCh0, dq_map,
43 sizeof(memory_params->DqByteMapCh0) * 2);
44 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
45 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
46 memcpy(memory_params->RcompResistor, RcompResistor,
47 sizeof(memory_params->RcompResistor));
/src/mainboard/google/glados/variants/sentry/variant.c: 54 in
variant_memory_init_params()
48 const u16 *targeted_rcomp = RcompTarget;
49
50 /* Override Rcomp Target assignment for specific SKU(s) */
51 if (spd_index == K4E6E304EE_MEM_ID)
52 targeted_rcomp = StrengthendRcompTarget;
53
>>> CID 1401338: (OVERRUN)
>>> Overrunning array "memory_params->DqByteMapCh0" of 12 bytes by passing
>>> it to a function which accesses it at byte offset 23 using argument "24UL".
>>> [Note: The source code implementation of the function has been overridden
>>> by a builtin model.]
54 memcpy(memory_params->DqByteMapCh0, dq_map,
55 sizeof(memory_params->DqByteMapCh0) * 2);
56 memcpy(memory_params->DqsMapCpu2DramCh0, dqs_map,
57 sizeof(memory_params->DqsMapCpu2DramCh0) * 2);
58 memcpy(memory_params->RcompResistor, RcompResistor,
59 sizeof(memory_params->RcompResistor));
60 memcpy(memory_params->RcompTarget, targeted_rcomp,
61 sizeof(memory_params->RcompTarget));
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbLuoVetFLSjdonCi1EjfHRqWGQvojmmkYaBE-2BPJiTQvaU4HClancRgJSp1vcdHRWU-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5Y2IXkn3C51gh1H77DON5SbKXCCbVsRnx5l1z4UvOWr-2Fa925EFSJF0VS539mlfXV695nciy5-2BjJbU3-2FpJfIRgcaofUit1Hyp7WNcGDUtUECEkZMQmpGyOdYUfHwOG66MU-2Fg-2Bkxf7jmOzpHv-2BQr4IbZy5HfyfknwBkXXzQhYFpdw8YoTjt0asa4sxvTqAJUXq04-3D
_______________________________________________
coreboot mailing list -- [email protected]
To unsubscribe send an email to [email protected]
