Hi,
Please find the latest report on new defect(s) introduced to coreboot found
with Coverity Scan.
2 new defect(s) introduced to coreboot found with Coverity Scan.
25 defect(s), reported by Coverity Scan earlier, were marked fixed in the
recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1401717: Null pointer dereferences (FORWARD_NULL)
________________________________________________________________________________________________________
*** CID 1401717: Null pointer dereferences (FORWARD_NULL)
/src/drivers/intel/fsp1_1/car.c: 175 in mainboard_romstage_entry()
169 } else {
170 /* This leaks a mapping which this code assumes is
benign as
171 * the flash is memory mapped CPU's address space. */
172 fih =
find_fsp((uintptr_t)rdev_mmap_full(prog_rdev(&fsp)));
173 }
174
>>> CID 1401717: Null pointer dereferences (FORWARD_NULL)
>>> Passing null pointer "fih" to "cache_as_ram_stage_main", which
>>> dereferences it.
175 cache_as_ram_stage_main(fih);
176 }
177
178 void __weak car_mainboard_pre_console_init(void)
179 {
180 }
** CID 1401394: Null pointer dereferences (NULL_RETURNS)
/src/soc/intel/broadwell/romstage/raminit.c: 125 in raminit()
________________________________________________________________________________________________________
*** CID 1401394: Null pointer dereferences (NULL_RETURNS)
/src/soc/intel/broadwell/romstage/raminit.c: 125 in raminit()
119 mrc_cache_stash_data(MRC_TRAINING_DATA, 0,
120 pei_data->data_to_save,
121 pei_data->data_to_save_size);
122
123 printk(BIOS_DEBUG, "create cbmem for dimm information\n");
124 mem_info = cbmem_add(CBMEM_ID_MEMINFO, sizeof(struct
memory_info));
>>> CID 1401394: Null pointer dereferences (NULL_RETURNS)
>>> Dereferencing a pointer that might be null "mem_info" when calling
>>> "memset". [Note: The source code implementation of the function has been
>>> overridden by a builtin model.]
125 memset(mem_info, 0, sizeof(*mem_info));
126 /* Translate pei_memory_info struct data into memory_info
struct */
127 mem_info->dimm_cnt = pei_data->meminfo.dimm_cnt;
128 for (int i = 0; i < MIN(DIMM_INFO_TOTAL, PEI_DIMM_INFO_TOTAL);
i++) {
129 struct dimm_info *dimm = &mem_info->dimm[i];
130 const struct pei_dimm_info *pei_dimm =
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbLuoVetFLSjdonCi1EjfHRqWGQvojmmkYaBE-2BPJiTQvaU4HClancRgJSp1vcdHRWU-3D_q4bX76XMySz3BXBlWr5fXXJ4cvAsgEXEqC7dBPM7O5YzNhHsc7Zip24AhFqKZYP6GhKmYyWAC-2F-2Bkk8yCWO-2BeCdOU74sNbSxtHA8vtpUUY9IXHPblCY1ldVt0spNebxaYjsbtWpvLVw5u7wmpNBj6sqIe2xk8NYI7Kd1me6hokLv0-2FVDe8YyBnAvGjmijZUcztUusSFo58Tb0SgWGFoHb88JdKDU5cItGppgdDPoFLzY-3D
_______________________________________________
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org
