First of all there is not even a single board status entry for bettong. Please upload one from the commit Kyösti pointed.
Regarding the AMD_S3_SAVE, see coreboot/src/vendorcode/amd/pi/00660F01/AMD.h line 129 and later: /* When AMD rolled out CarrizoPI, they made a bad choice of removing * an entry from the middle of the enumeration list. */ #if 0 /* This was removed, shifting everything else up.*/ AMD_S3_SAVE = 0x0002C000, #endif I think Kyösti could share a little bit more details on that (commit 55fffa29c23). Regards, Michał On 03.12.2019 14:57, Jorge Fernandez Monteagudo wrote: >> Here is a short guide how to upload board status: >> >> https://github.com/coreboot/coreboot/blob/master/util/board_status/README >> >> The system you are going to boot has to have cbmem installed. > Hi Michal, > > Do you have already any patch to test? I've updated to the last git and > enabled the AMD Bettong > board (it's disabled in Kconfig.name!) but it's not compiling. There are > several errors: > > 1) > src/drivers/amd/agesa/state_machine.c: In function 'ramstage_dispatch': > src/drivers/amd/agesa/state_machine.c:216:8: error: 'AMD_S3_SAVE' undeclared > (first use in this function); did you mean 'AMD_INIT_LATE'? > > 2) > src/mainboard/amd/bettong/OemCustomize.c:130:6: error: no previous prototype > for 'OemCustomizeInitEarly' [-Werror=missing-prototypes] > VOID OemCustomizeInitEarly ( > src/mainboard/amd/bettong/OemCustomize.c:149:6: error: no previous prototype > for 'OemPostParams' [-Werror=missing-prototypes] > void OemPostParams(AMD_POST_PARAMS *PostParams) > > 3) > src/mainboard/amd/bettong/romstage.c:34:7: error: 'cpu_init_detectedx' > undeclared (first use in this function); did you mean 'cpu_index'? > if (!cpu_init_detectedx && boot_cpu()) { > src/mainboard/amd/bettong/romstage.c:34:7: note: each undeclared identifier > is reported only once for each function it appears in > src/mainboard/amd/bettong/romstage.c:51:2: error: implicit declaration of > function 'AGESAWRAPPER'; did you mean 'AGESA_READ_SPD'? > [-Werror=implicit-function-declaration] > AGESAWRAPPER(amdinitreset); > src/mainboard/amd/bettong/romstage.c:51:15: error: 'amdinitreset' undeclared > (first use in this function); did you mean 'AmdInitReset'? > AGESAWRAPPER(amdinitreset); > src/mainboard/amd/bettong/romstage.c:56:15: error: 'amdinitearly' undeclared > (first use in this function); did you mean 'AmdInitEarly'? > AGESAWRAPPER(amdinitearly); > src/mainboard/amd/bettong/romstage.c:59:15: error: 'amdinitpost' undeclared > (first use in this function); did you mean 'AmdInitPost'? > AGESAWRAPPER(amdinitpost); > src/mainboard/amd/bettong/romstage.c: In function 'agesa_postcar': > src/mainboard/amd/bettong/romstage.c:65:15: error: 'amdinitenv' undeclared > (first use in this function); did you mean 'AmdInitEnv'? > AGESAWRAPPER(amdinitenv); > src/mainboard/amd/bettong/romstage.c:28:13: error: 'romstage_main_template' > defined but not used [-Werror=unused-function] > > Regards, > Jorge > _______________________________________________ > coreboot mailing list -- coreboot@coreboot.org > To unsubscribe send an email to coreboot-le...@coreboot.org -- Michał Żygowski Firmware Engineer http://3mdeb.com | @3mdeb_com _______________________________________________ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-le...@coreboot.org
