Hey! But as long as Buildship requires Guava 15, it will end up in the simrel repo. And I thought that Orbit should be the only source of third-party dependencies… ;-)
Cheers, -Martin > Am 21.08.2018 um 10:49 schrieb Donát Csikós <[email protected]>: > > The Buildship update sites contain the required dependencies too, so from our > POV Guava 15 can be safely removed from Orbit. > > > Martin Lippert <[email protected]> ezt írta (időpont: 2018. aug. 20., H, > 20:10): > Hey Mat, > > as far as I remember Buildship will update to Guava 21 (from 15) for the > 2018-12 release. Sounds like we can’t remove that old Guava Version from > Orbit for the 2018-09 release. > > Just wanted to point that out, in case that piece of the puzzle got lost > somewhere... :-) > > Cheers, > Martin > > > > Am 20.08.2018 um 17:51 schrieb Mat Booth <[email protected]>: > >> On 2 August 2018 at 17:19, Mat Booth <[email protected]> wrote: >> On 2 August 2018 at 16:53, Mat Booth <[email protected]> wrote: >> >> >> On 2 August 2018 at 07:53, Andreas Sewe <[email protected]> wrote: >> Hi Roland, >> >> > I just wanted to give a heads-up that the following bundles (and >> > corresponding source bundles) are expected to be removed from the Orbit >> > build towards 2018-09, for M3 [1]. >> > >> > com.google.guava 15.0.0, 18.0.0 (use 21.0.0) >> >> Code Recommenders still uses Guava 15 and can't switch without doing a >> major release, as Guava classes like ImmutableList and Optional are >> unfortunately part of our public API. Switching to a new major version >> of Guava would hence mean forcing all our clients to also switch, which >> may not be possible. >> >> A major release, possibly moving from Guava Optional to Java 8 Optional >> in our public APIs, would eliminate this problem for good, but we don't >> have the resources to do that for 2018-09. >> >> Best wishes, >> >> Andreas >> >> >> Here I might be able to help. That recommenders uses old guava has caused me >> a bit of headache in my downstream builds and I've been carrying some >> patches against recommenders for a while -- let me clean up the patches that >> we are carrying downstream and I will file a bug where we can discuss it >> further -- how does that sound? >> >> Sorry for replying to myself. I filed two bugs to talk about it: >> >> https://bugs.eclipse.org/bugs/show_bug.cgi?id=537624 >> https://bugs.eclipse.org/bugs/show_bug.cgi?id=537625 >> >> >> >> Hi all, >> >> I submitted patches for these bugs (for aligning guava versions with the >> rest of the train) but received no feedback yet from the recommenders >> project. I'm also still not sure what is wrong with their jenkins instance >> -- I lack sufficient privileges to investigate, but I tried to re-create the >> build on my own personal jenkins instance and I couldn't reproduce the >> problem. Please see the above bugs for details, and please comment if anyone >> has any recommendation on how best to proceed. >> >> Thanks, >> Mat >> _______________________________________________ >> cross-project-issues-dev mailing list >> [email protected] >> To change your delivery options, retrieve your password, or unsubscribe from >> this list, visit >> https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev > _______________________________________________ > cross-project-issues-dev mailing list > [email protected] > To change your delivery options, retrieve your password, or unsubscribe from > this list, visit > https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev > _______________________________________________ > cross-project-issues-dev mailing list > [email protected] > To change your delivery options, retrieve your password, or unsubscribe from > this list, visit > https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev _______________________________________________ cross-project-issues-dev mailing list [email protected] To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/cross-project-issues-dev
